Patch for individual session requests from chilli.sock for consideration.

wlanmac wlan at mac.com
Thu May 21 07:39:50 UTC 2009


committed at rev 201


On Thu, 2009-05-21 at 17:07 +1000, Scott Tester wrote:
> I am working at integrating coovachilli with dansguardian.  Sending
> the list command to the socket returns the data for all active
> sessions.  As I want to keep the socket communication to a minimum,
> I've modified coovachilli (see attached patch) to return only the ip
> or mac requested.
> Would you consider merging these changes* for two reasons:
> 1. Other's can benifit.
> 2. I don't have to modify the source each time I upgrade coova on my
> system.
> 
> 
> NOTES:
> 1.  There are two lines that didn't want to compile due to a required
> third argument when open() uses O_CREAT, (chilli.patch:9 &
> chilli.patch:18).  This is not the main reason for this patch, but
> I've included these fixes anyway.
> 2.  I'm not fussed if anyone has a better idea for command names
> instead of 'listip' and 'listmac'.  Same goes for
> CMDSOCK_ENTRY_FOR_MAC and CMDSOCK_ENTRY_FOR_IP.
> 
> 
> * I understand that you will want to review the code.  In fact, that
> would be appreciated - if you don't mind.
> -- 
> 
> 
> Scott Tester 
> 
> IT Department
> 
> SMBC  www.smbc.com.au
> 
> Sydney Missionary and Bible College
> 
> 43 Badminton Road, Croydon NSW 2132
> 
> Phone: 02 9747 4780  ext 147
> 
> Mobile: 0411 145 584
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: chilli-unsubscribe at coova.org
> For additional commands, e-mail: chilli-help at coova.org
> Wiki: http://coova.org/wiki/index.php/CoovaChilli
> Forum: http://coova.org/phpBB3/viewforum.php?f=4




More information about the Chilli mailing list