[Chilli] [Patch] Fix access_request() to conform with radius pack ID semantics

[David Bird]

Hi Pieter,

Could you review your patch (first chunk) against the subversion? 

I had made some changes around that code... specifically, I don't
believe your patch takes note of the situation where access_request()
returns a Reject. This is why the following is done:

  int id;
  ...
  id = radius_pack.id;
  radius_pack.id = pack->id;

  ... possible radius_resp() with reject which needs id of req...

  appconn->radiusid = pack->id;  // Noted so that later we can reply
with correct id
  ...
  radius_pack.id = id;

  return radius_req(radius, &radius_pack, appconn);

David

On Wed, 2010-05-19 at 15:23 +0200, IT-Systemmanagement Pieter Hollants
wrote:
> Please find attached a new version of my original patch posted on May
> 16. There was another cause of "No such id in radius queue" errors
> within chilli.c:access_request(), caused by the modified RADIUS packet
> ID assignment semantics.
> 
> David, all you need to know is inside the patch's new second hunk :)
> 
> _______________________________________________
> Chilli mailing list
> Chilli at coova.org
> http://lists.coova.org/cgi-bin/mailman/listinfo/chilli