[Chilli] [Patch] Fix auth state in redir_main()

David Bird david at coova.com
Sat May 22 05:12:04 UTC 2010

Thanks, though, there isn't really any harm in reusing the variable
since it's never part of any conditional. It amounts to:

  int state = 0; /* initialization not really needed */

  state = func();
  if (state) /* something */

  state = func();
  switch(state) /* something */


On Fri, 2010-05-21 at 21:14 +0200, IT-Systemmanagement Pieter Hollants
> Hi David,
> in current SVN you modified the redir_getreq() call in
> redir.c:redir_main() to inspect the error code returned:
>  state = redir_getreq(...)
> This breaks the code further below which relies on state to represent
> the auth. state (such as under REDIR_LOGIN).
> Attached patch uses a seperate variable for the redir_getreq() return code.

More information about the Chilli mailing list