[Chilli] Does option noradallow effect radconf only?

[Steffen Dettmer]

Hi,

> ... the effect of --noradallow ...

when changing redir_cb_radius_auth_conf() to handle timeout as
REDIR_SUCCESS with session_param_defaults(), what would be bad
consequences? (Of course it is doubtful whether it makes sense at
all to authenticate everyone when no RADIUS server is available,
except maybe for test automation or other really special cases).

Steffen



--- ../../coova-chilli/coova-chilli-1.3.1-svn/src/redir.c       2013-01-24 01:32:23.000000000 +0100
+++ redir.c     2013-12-02 13:42:48.834270456 +0100
@@ -2442,6 +2442,13 @@
   
   if (!pack) { /* Timeout */
     log_err(0, "Radius request timed out");
+    if (_options.noradallow) {
+      log_info("RADIUS timeout but noradallow: default redir session.");
+      session_param_defaults(&conn->s_params);
+      conn->response = REDIR_SUCCESS;
+      return 0;
+    }
+    log_info("RADIUS timeout and no noradallow: timeout redir session.");
     conn->response = REDIR_FAILED_TIMEOUT;
     return 0;
   }