[Chilli] Two trivial patches for "--with-nfcoova" (kmod-coova / xt_coova)

[Steffen Dettmer]

Hi,

two trivial patches for "--with-nfcoova":


nfcoova-compile-fix.patch

Makes compilable but commenting out assignment to non-existent
field "appconn->s_state.last_sent_time".
Note: there are no other references to "last_sent_time" in all the sources.



nfcoova-compile-fix.patch

Fixes libxt_coova.c function coova_print() and coova_save() to
generate correct iptables-save output.

Note: All libxt_samples I found follow the convention that each
printf starts with blank but does not end with one, so I did
here.

Note: the option --source cannot be used, it clashes with
iptables --source (in contrast to --dest, which does not clash
with --destination), fortunately it is default, so no need to
specify on command line or show in iptables-save.

This changes the previously wrong iptables-save output from e.g.:

-A FORWARD -s 10.0.0.0/8 -o uplink-tun -m coova--name chilli --dest  -j ACCEPT
-A FORWARD -s 10.0.0.0/8 -o uplink-tun -m coova--name chilli --source  -j ACCEPT

to e.g.:

-A FORWARD -s 10.0.0.0/8 -o uplink-tun -m coova --name chilli --dest -j ACCEPT
-A FORWARD -s 10.0.0.0/8 -o uplink-tun -m coova --name chilli -j ACCEPT

Note: the clash of option "--source" is not solved by this patch,
it still appears e.g. in coova_help(). I think the option could
be renamed or removed. If advice given I might be able to
contribute a patch.

Any comments appreciated.

Regards,
Steffen


-------------- next part --------------
A non-text attachment was scrubbed...
Name: Contributing
Type: application/octet-stream
Size: 3392 bytes
Desc: Contributing
URL: <http://lists.coova.org/pipermail/chilli/attachments/20131203/539cec34/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: nfcoova-compile-fix.patch
Type: application/octet-stream
Size: 416 bytes
Desc: nfcoova-compile-fix.patch
URL: <http://lists.coova.org/pipermail/chilli/attachments/20131203/539cec34/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: iptables-save-fix.patch
Type: application/octet-stream
Size: 898 bytes
Desc: iptables-save-fix.patch
URL: <http://lists.coova.org/pipermail/chilli/attachments/20131203/539cec34/attachment-0002.obj>